Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Livery for heads to match departments #334

Merged

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 27, 2024

as reported here https://discord.com/channels/714022226810372107/1317251464242135132/1321969505575895040 custom livery for department heads is wrong

Summary by Sourcery

Bug Fixes:

  • Fixed an issue where heads did not have the correct livery.

Copy link
Contributor

sourcery-ai bot commented Dec 27, 2024

Reviewer's Guide by Sourcery

This pull request updates the setup_complex_livery_shader function to apply custom liveries to character heads based on their department, such as Apothecary, Techmarine, Librarian, and Chaplain. It uses the is_specialist function to check for these specific roles and assigns the corresponding livery from the obj_ini.full_liveries array. If no specialist role is found, it defaults to the existing logic of iterating through the obj_ini.role array.

File-Level Changes

Change Details Files
Added custom livery support for character heads based on department.
  • Added conditional checks for specialist roles like Apothecary, Techmarine, Librarian, and Chaplain within the setup_complex_livery_shader function.
  • Used is_specialist function to determine the character's department.
  • Assigned specific liveries from obj_ini.full_liveries based on the identified department.
  • Preserved the original logic for non-specialist roles using the obj_ini.role array as a fallback.
  • Added local variables _full_liveries and _roles for readability and efficiency.
scripts/scr_complex_colour_kit/scr_complex_colour_kit.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Dec 27, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using constants or enums instead of magic strings ('apoth', 'forge', etc.) for specialist role checks to improve maintainability and prevent typo-related bugs
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 4fcd7c8 into Adeptus-Dominus:release/0.10.0.0 Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant