fix: Custom chapter image load error

[EttyKitty]

Summary by Sourcery

Fix loading custom chapter images by handling cases where the image path is not set and adding error handling to the image caching function.

Bug Fixes:

• Fixed an issue that prevented custom chapter images from loading correctly.
  https://discord.com/channels/714022226810372107/1322013691587072051
• And another issue with the wrong array_push target.

Enhancements:

• Wrapped scr_image_cache into try-catch.
• Formatted scr_image_cache.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug that prevented custom chapter images from loading. The fix involves adding a check for empty image paths and wrapping the image caching function in a try-catch block to handle potential errors.

File-Level Changes

Change	Details	Files
Handle cases where the image path is not set	Added a check to ensure that the chapter_icon_path is not empty before attempting to load a custom chapter image. This prevents errors when the path is not set. If the path is empty, the default chapter icon (spr_icon_chapters) is used instead of attempting to load a custom image from a non-existent path.	scripts/scr_load/scr_load.gml
Wrap the image caching function in a try-catch block	Wrapped the scr_image_cache function in a try-catch block to handle potential errors during image loading and caching. Added error handling to the scr_image_cache function to prevent crashes when trying to access an invalid image path or ID. Formatted the scr_image_cache function for improved readability and maintainability.	scripts/scr_image/scr_image.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Array expansion pushes to wrong array - should be obj_img.image_cache[path] not obj_img.image_cache (link)

Here's what I looked at during the review

• 🔴 General issues: 1 blocking issue
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}