fix: Initialisation sequences in load causing crashes

[OH296]

Summary by Sourcery

Bug Fixes:

• Prevent crashes caused by missing chapter icon sprites during loading.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a crash that occurred during the game's loading sequence. The crash was caused by the game attempting to draw a sprite that had not yet been loaded. To fix this, the code now checks if the sprite exists before attempting to draw it. Additionally, the pull request changes the initialization sequence for specialist points to prevent another crash. The specialist point handler is now initialized in the load controller, ensuring it is available before it is used in the load script.

File-Level Changes

Change	Details	Files
Check if the chapter icon sprite exists before drawing it.	Added a conditional check around the draw_sprite_stretched function to prevent it from being called if the sprite does not exist.	objects/obj_controller/Draw_64.gml
Set a default chapter icon sprite if the specified icon path is invalid.	Changed the conditional check for loading the chapter icon sprite to use the error string "Error" instead of an empty string. Set the chapter icon sprite to a default sprite if the specified path is invalid.	scripts/scr_load/scr_load.gml
Initialize the specialist point handler in the load controller.	Removed the initialization of the specialist point handler from the load script. Added the initialization of the specialist point handler to the load controller.	objects/obj_saveload/Alarm_0.gml scripts/scr_load_controller/scr_load_controller.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider implementing a more systematic error handling approach for sprite loading failures, rather than using hardcoded fallbacks. This could be addressed in a future PR.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}