Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update access key name #325

Merged
merged 1 commit into from
Dec 26, 2024
Merged

ci: Update access key name #325

merged 1 commit into from
Dec 26, 2024

Conversation

EttyKitty
Copy link
Collaborator

@EttyKitty EttyKitty commented Dec 26, 2024

Summary by Sourcery

CI:

  • Use GM_ACCESS_KEY secret instead of ACCESS_KEY for the GameMaker build workflow.

@EttyKitty EttyKitty added the PR: CI Continuous Integration changes label Dec 26, 2024
Copy link
Contributor

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

This pull request updates the name of the access key used in the gamemaker_build workflow from ACCESS_KEY to GM_ACCESS_KEY.

File-Level Changes

Change Details Files
Update access key name
  • The access-key parameter in the igor_publish step has been updated from ACCESS_KEY to GM_ACCESS_KEY.
.github/workflows/gamemaker_build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Chore Does something that does't fit other labels label Dec 26, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please verify that the GM_ACCESS_KEY secret is properly configured in the repository settings to prevent CI failures.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty merged commit 5f2d83f into main Dec 26, 2024
1 check passed
@EttyKitty EttyKitty deleted the EttyKitty-patch-1 branch December 26, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Chore Does something that does't fit other labels PR: CI Continuous Integration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant