Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: draw unit image comparing arrays not possible #323

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 26, 2024

Summary by Sourcery

Bug Fixes:

  • Fix the condition to check for non-empty bionic options array using array_length instead of direct comparison.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #323 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 1273.

@github-actions github-actions bot added PR: Sprites Changes to sprites/images PR: Major Coding Big enough to possibly clash with other PRs labels Dec 26, 2024
@OH296 OH296 changed the base branch from main to release/0.10.0.0 December 26, 2024 19:00
@OH296 OH296 changed the title Fix : draw unit image comparing arrays not possible fix : draw unit image comparing arrays not possible Dec 26, 2024
@OH296
Copy link
Collaborator Author

OH296 commented Dec 26, 2024

@sourcery-ai review

Copy link
Contributor

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

The pull request fixes an issue in the 'scr_draw_unit_image' function where a direct comparison of an array was replaced with a check using the 'array_length' function to ensure proper evaluation of non-empty arrays.

File-Level Changes

Change Details Files
Fixed array comparison issue in drawing unit image function
  • Replaced direct array comparison with array_length function to check if array is not empty
scripts/scr_draw_unit_image/scr_draw_unit_image.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 added I: Bug and removed PR: Major Coding Big enough to possibly clash with other PRs PR: Sprites Changes to sprites/images labels Dec 26, 2024
@OH296 OH296 merged commit c9ab86d into Adeptus-Dominus:release/0.10.0.0 Dec 26, 2024
1 check passed
@EttyKitty EttyKitty changed the title fix : draw unit image comparing arrays not possible fix: draw unit image comparing arrays not possible Dec 26, 2024
@EttyKitty EttyKitty added PR: Fix This is a fix for a bug and removed I: Bug labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants