Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow renaming Marines #217

Closed
GalacticChimp opened this issue Nov 16, 2023 · 4 comments
Closed

Allow renaming Marines #217

GalacticChimp opened this issue Nov 16, 2023 · 4 comments
Assignees
@GalacticChimp
Labels
Legacy Things from the old repository.
Milestone
0.10.0 - Legacy

Comments

@GalacticChimp
Copy link
Collaborator

GalacticChimp commented Nov 16, 2023 •
edited
Loading

Description

Enabling Marine renaming is flavorful, would definitely be nice to have that ability.

Proposed change

  • Allow renaming Marines (just in Company view should be enough)
  • obviously add validation (just check for empty. Players should be able to have Marines named the same, HOWEVER during sector generation names should get duplicated only rarely)
@GalacticChimp GalacticChimp added this to the backlog milestone Nov 16, 2023
@GalacticChimp GalacticChimp modified the milestones: backlog, 0.8.3.0 Nov 16, 2023
@GalacticChimp
Copy link
Collaborator Author

moved to 0.8.3.0 milestone, but it's tentative, we might not have enough time to do implement this, so it might get moved to 0.8.4.0

@OH296
Copy link
Collaborator

OH296 commented Nov 16, 2023 •
edited
Loading

Description

Enabling Marine renaming is flavorful, would definitely be nice to have that ability. However, this cannot be properly done until Marines are refactored into structs.

marines are already refactored into structs?

Also probably quite easy to fit this in i'll just rejiggle the code that allows you to rename companies and slap it on marines as long as teh player can't put "" as the name it should be fine

@GalacticChimp
Copy link
Collaborator Author

GalacticChimp commented Nov 16, 2023 •
edited
Loading

marines are already refactored into structs?

ok, I thought you were still doing some stuff with them. Ok, then this just got unblocked.

Updated issue description.

@GalacticChimp GalacticChimp assigned OH296 and GalacticChimp and unassigned OH296 Nov 16, 2023
@GalacticChimp
Copy link
Collaborator Author

misclicked

@GalacticChimp GalacticChimp modified the milestones: 0.9.0, 0.10.0 Dec 31, 2023
@GalacticChimp GalacticChimp mentioned this issue Dec 31, 2023
Closed
OH296 added a commit to OH296/ChapterMaster that referenced this issue Dec 17, 2024
@OH296
fix: Add error handling and split crusade into own function (Adeptus-…
280bba3 
…Dominus#217)

hopefully either solves or provides better error handling for this:
https://discord.com/channels/714022226810372107/1312791321068572793
@EttyKitty EttyKitty added Legacy Things from the old repository. and removed I: Feature labels Dec 26, 2024
@EttyKitty EttyKitty closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GalacticChimp GalacticChimp

Labels
Legacy Things from the old repository.
Projects
None yet
Milestone
0.10.0 - Legacy
Development

No branches or pull requests
3 participants
@EttyKitty @GalacticChimp @OH296