Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow renaming ships #215

Open
GalacticChimp opened this issue Nov 16, 2023 · 0 comments
Open

Allow renaming ships #215

GalacticChimp opened this issue Nov 16, 2023 · 0 comments
Labels
I: Feature A new feature, or an expansion of an existing feature, which required code changes
Milestone
backlog

Comments

@GalacticChimp
Copy link
Collaborator

GalacticChimp commented Nov 16, 2023 •
edited
Loading

Description

Enabling ship renaming is flavorful, would definitely be nice to have that ability. However, this cannot be properly done until ships (and optimally fleets as well) are refactored into structs. Without the refactor we won't have proper ids for ships.

Proposed change

  • Allow renaming ships (just in Fleets tab should be enough)
  • obviously add validation (just check for empty. Players should be able to have ships named the same, HOWEVER during sector generation names should NOT get duplicated)

Additional information

Related to #217
@GalacticChimp GalacticChimp added the I: Feature A new feature, or an expansion of an existing feature, which required code changes label Nov 16, 2023
@GalacticChimp GalacticChimp modified the milestones: 0.8.4.0, backlog Nov 16, 2023
OH296 added a commit to OH296/ChapterMaster that referenced this issue Dec 17, 2024
@OH296
fix: Unset global variable crashing artificer armour (Adeptus-Dominus…
dd0af92 
…#215)

add error handling to drawing unit imagine.
as stated should fix:
https://discord.com/channels/714022226810372107/1318224998179012669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: Feature A new feature, or an expansion of an existing feature, which required code changes
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@GalacticChimp