Merge pull request #2314 from AdaptiveConsulting/chore/5617-vitest2

chore: upgrade vitest to v2

packages/client/.gitignore

@@ -3,10 +3,8 @@ dist/
 
 # misc
 *.local
-.eslintcache
 
 # testing
 test-data
 /test-results/
 /playwright-report/
-/playwright/.cache/

packages/client/eslint.config.js

@@ -1,4 +1,5 @@
 import js from "@eslint/js"
+import pluginImport from "eslint-plugin-import"
 import react from "eslint-plugin-react"
 import hooks from "eslint-plugin-react-hooks"
 import simpleImportSort from "eslint-plugin-simple-import-sort"
@@ -12,22 +13,35 @@ import tseslint from "typescript-eslint"
 // ... and even then eslint-plugin-react has no (useful) types .. sigh
 //
 export default [
+  {
+    // these are global ignores, cascading down to each config block, which can have its own
+    // more targeted ignores, if necessary
+    ignores: ["dist", "coverage", "*.config.js"],
+  },
+
+  // ESLint's own core recommended rules
+  // the FlatConfig equivalent of:  extends: [ 'eslint:recommended' ]
   js.configs.recommended,
+
+  // https://typescript-eslint.io/getting-started/
+  // Note:
+  //   it is an array (base, recommended), so we have to spread it...
+  //   see node_modules/typescript-eslint/dist/configs/base.js
+  //   "base" contains the parser/plugin config, so we don't have to include that manually below
   ...tseslint.configs.recommended,
   {
     plugins: {
-      // https://github.com/lydell/eslint-plugin-simple-import-sort
-      "simple-import-sort": simpleImportSort,
-      // https://typescript-eslint.io/getting-started/
-      "@typescript-eslint": tseslint.plugin,
       // https://github.com/jsx-eslint/eslint-plugin-react
       react,
       // https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks
       // compat with ESLint v9, see https://github.com/facebook/react/issues/28313
       "react-hooks": hooks,
+      // https://github.com/import-js/eslint-plugin-import
+      import: pluginImport,
+      // https://github.com/lydell/eslint-plugin-simple-import-sort
+      "simple-import-sort": simpleImportSort,
     },
     languageOptions: {
-      parser: tseslint.parser,
       parserOptions: {
         ecmaFeatures: {
           jsx: true,
@@ -39,6 +53,9 @@ export default [
         ...globals.browser,
       },
     },
+    linterOptions: {
+      reportUnusedDisableDirectives: "error",
+    },
     settings: {
       react: {
         version: "detect",
@@ -73,8 +90,12 @@ export default [
 
       // with new flat config, we need to "switch on" the import errors
       // ref https://github.com/lydell/eslint-plugin-simple-import-sort#usage
+      // per example: https://github.com/lydell/eslint-plugin-simple-import-sort#example-configuration
       "simple-import-sort/imports": "error",
       "simple-import-sort/exports": "error",
+      "import/first": "error",
+      "import/newline-after-import": "error",
+      "import/no-duplicates": "error",
 
       // as hooks plugin does not play well with Flat Config right now, do this
       ...hooks.configs.recommended.rules,