Ruby- Mikayla H #68
Open
Ruby- Mikayla H #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay an entire chat log
| export default ChatLog; | ||
|
|
||
|
|
||
| ChatLog.propTypes = { |
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ), |
There was a problem hiding this comment.
Remember to add an .isRequired here or else the entries prop is not required!
| import React from 'react'; | ||
| import ChatEntry from './ChatEntry'; | ||
| import PropTypes from 'prop-types' | ||
|
|
There was a problem hiding this comment.
This would be a great place to add the ChatLog.css import!
| </section> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
|
|
||
| ChatEntry.propTypes = { |
There was a problem hiding this comment.
Yay, prop types! It would be good to make sure all of the props are here (like id).
| @@ -1,22 +1,34 @@ | |||
| import React from 'react'; | |||
| import './ChatEntry.css'; | |||
| import PropTypes from 'prop-types'; | |||
| import TimeStamp from './TimeStamp' | |||
|
|
|||
|
|
|||
| const ChatEntry = (props) => { | |||
|
|
||
| setEntries(updatedEntries); | ||
| } | ||
| const newLikedCount = entries.filter( |
There was a problem hiding this comment.
Minor note: this line is not indented correctly.
|
|
||
| const App = () => { | ||
|
|
||
| const [entries, setEntries] = useState(chatMessages); |
| //use state | ||
| // create func to update likes | ||
| //creat func to count likes | ||
|
|
||
|
|
||
| const App = () => { |
| @@ -1,19 +1,49 @@ | |||
| import React from 'react'; | |||
| import './App.css'; | |||
| import chatMessages from './data/messages.json'; | |||
| import ChatEntry from './components/ChatEntry'; | |||
There was a problem hiding this comment.
This import is not needed! It's best practice to remove unused imports before submitting projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.