Lions - Tara Alsaidi #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeStamp components
…ated updateMessages callback function connected to onClick functionality in ChatEntry, created variable styling for liked functionality and remote vs. local sender
…rack total number of likes in App.js and display this number in the header
alope107
reviewed
Feb 17, 2023
Comment on lines
+8
to
+9
| const [messagesList, setMessageList] = useState(chatMessages); | ||
| const [likesCounter, setLikesCounter] = useState(0); |
There was a problem hiding this comment.
Because we can determine the number of likes from messagesList, likesCounter should not be its own state variable. In general, we want state variables to not depend on one another, otherwise we get multiple sources of truth and increase the risk of bugs.
Comment on lines
+24
to
+29
| if (id === message.id) { | ||
| message.liked = !message.liked; | ||
| return message; | ||
| } else { | ||
| return message; | ||
| } |
There was a problem hiding this comment.
Small nitpick: the else is not needed here.
| import TimeStamp from './TimeStamp'; | ||
|
|
||
| const ChatEntry = ({ id, sender, body, timeStamp, liked, onLikeClick }) => { | ||
| const localOrRemote = |
| @@ -1,22 +1,41 @@ | |||
| import React from 'react'; | |||
| import './ChatEntry.css'; | |||
| import PropTypes from 'prop-types'; | |||
| import TimeStamp from './TimeStamp'; | |||
|
|
|||
| const ChatEntry = ({ id, sender, body, timeStamp, liked, onLikeClick }) => { | |||
Comment on lines
+21
to
+23
| onClick={() => { | ||
| onLikeClick(id); | ||
| }} |
Comment on lines
+31
to
+39
| messages: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.func, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ), |
There was a problem hiding this comment.
Make sure to make the overall array as required as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.