Pipes - Bennett - Trek

[bennettrahn]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	can load at different times
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	the form to submit a reservation had to be loaded only when you clicked on it. I had to include a div to put it in on click.
What kind of errors might the API give you? How did you choose to handle them?	I didn't. I ran out of time.
Do you have any recommendations on how we could improve this project for the next cohort?	nope.

[droberts-sea]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes - Regarding asynchronous code, anything that runs at some unspecified time in the future is asynchronous, whether or not it has to do with loading content. Usually this means it's responding to an external event like something the user did or an API response.
Functionality
Click a button to list trips	yes
Click a trip to see trip details	yes
Fill out a form to reserve a spot	yes
Errors are reported to the user	no - the version of the API for this project does not have any errors to report, so this requirement ends up not being very interesting
Styling, Foundation grid layout	yes
Under the Hood
Trip data is retrieved using jQuery AJAX	yes
JavaScript is well-organized and easy to read	yes - great work
HTML is semantic	no - you have lots of <div>s where you could be using a tag with more semantic weight. Remember that a screen reader needs these semantic tags whether or not content is loaded dynamically.
Overall	Good work overall! Your javascript is very well organized, and it seems like you've got a good handle on both async callbacks and on manipulating the DOM. These things will get trickier as we continue to build larger and more dynamic webapps, so keep up the focus and hard work!

[droberts-sea]

One strategy for getting the others to collapse automatically would be to wrap the generated trip details in a <div class="trip-details">, and then say $('.trip-details').remove().