Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lauren Cardella -- Carets #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

enigmagnetic
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that many requests and responses can happen at once, while interaction with the page continues.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I'm not sure how to identify asynchronous code. Only one API call is sent at a time for the list, a filtered list, a trip, or a reservation. The page interactions are not complex.
What kind of errors might the API give you? How did you choose to handle them? The API might return an error for an invalid URL parameter or if data failed to save. In both cases a message is returned to the user stating that the data failed to save. This doesn't seem to be working when an invalid trip ID is passed to the API, though it's supposed to show an error also.
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Too few commits!!! I see you recognize that you forgot!
Comprehension questions Check, your click handler can be executed at the same time as API requests. They are asynchronous as are your ajax calls.
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Check, nice work!
Styling, Foundation grid layout No grid, but the styling is nice and attractive.
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Please turn on your linter, just some minor things that it would help clean up. Overall the JS code is pretty well organized.
HTML is semantic Overall pretty semantic
Overall Well done, nice work with the continent filtering. Great work!

$('button#search').html('Find Trips');
});

$('button.continent').click(function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In places like this, naming the handler is better, something like:

$('button.continent').click(function filterByContinent() {

@@ -0,0 +1,91 @@
$(document).ready( function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

places like this where you're not using this make good places to use an arrow function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants