Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jocelyn Gonzalez -- Carets #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jocegonz
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? **Note re: project. Main button works on one click, each trip button works on double-click :( ** It means it won't run in order from top to bottom.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? My loadTrips function runs asynchronous to the rest of my loaded page. This meant I had to load information regarding my list of trips when a user requested it.
What kind of errors might the API give you? How did you choose to handle them? It could tell me when my request for information failed or my form didn't submit.
Do you have any recommendations on how we could improve this project for the next cohort? Not really. It was very open-ended and it felt structured in a way that pushed us to figure things out on our own.

@tildeee
Copy link

tildeee commented Dec 2, 2017

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Functionality
Click a button to list trips x
Click a trip to see trip details x
Fill out a form to reserve a spot
Errors are reported to the user x
Styling, Foundation grid layout x
Under the Hood
Trip data is retrieved using jQuery AJAX x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Nice animations!

In loadTrips(), instead of concatenating to the string basicInfo, you may want to consider using jQuery and appending these elements using append()

Your reservation form doesn't work. Because the submit button within the form is also within an element with class panel, it's using the event listener on line 111.

also, try to remove your console.logs before PR submission please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants