Pipes - Tamira - Trek #27
Conversation
…at this is not such a nested mess
… less conviluted:
TREKWhat We're Looking For
Great job overall! In my estimation there are two difficult things in JavaScript we've never had to do in Ruby/Rails:
Based on this submission I'd say you have a good handle on both. These topics will get substantially more complex as we continue to build bigger apps with more moving parts, and having strong organization in your JavaScript code will be even more important. Keep up the focus and hard work! |
| // create a click event for the button to book a trip | ||
| $(`#trip${id}`).click((event) => { | ||
| // stops the tripHTML click event from running | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
This is a callback inside a callback inside a callback inside a callback inside a callback! To me, this is a good indicator that you should break some of these out into separate named functions, defined at the top of the file. Each jQuery event handler and AJAX success or failure callback should get its own function.
See also callback hell
| let form = $( | ||
| `<div id="book"> | ||
| <form action="${action}" method="post" id="book${id}"> | ||
| <label for="name">Name:</label> |
| // create click event for each trip name | ||
| tripHTML.on('click', '.details', (event) => { | ||
| let tripId = $(event.target).attr('id'); | ||
| getTripDetails(tripId); |
There was a problem hiding this comment.
This is a good effort at refactoring (certainly better than the original), but you're still in a triply nested callback here.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions