Mariana-Pipes-Trek

[lmarianarp19]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	Asynchronous means that you can do many things at once. For example you can send multiple AJAX request at the same time .
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	I show all the trip options. At the same time I can make a reservation. I decided to show both things at the same time, so half of the screen will have the trips result at the other half will have the trip details and the option to make a reservation.
What kind of errors might the API give you? How did you choose to handle them?	I will have some errors if the url is wrong. I will report this errors to the user.
Do you have any recommendations on how we could improve this project for the next cohort?	It will be useful to learn before what is the best way to make validations in a form.

[droberts-sea]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes - Regarding asynchronous code, anything that runs at some unspecified time in the future is asynchronous, including everything from AJAX success / failure callbacks to button click handlers.
Functionality
Click a button to list trips	yes
Click a trip to see trip details	yes
Fill out a form to reserve a spot	yes
Errors are reported to the user	yes
Styling, Foundation grid layout	yes
Under the Hood
Trip data is retrieved using jQuery AJAX	yes
JavaScript is well-organized and easy to read	yes - I like that you define most of your event handlers as named functions at the top of the file, and then attach them to events by name.
HTML is semantic	mostly - I see several places you use <div> where a more semantic tag would be appropriate.
Overall

Good work overall! In my estimation there are two difficult things in JavaScript we've never had to do in Ruby/Rails:

• Working with callback functions, especially in an asynchronous context
• Manipulating the DOM (and structuring the DOM to make it easy to manipulate)

Based on this submission I'd say you have a good handle on them. Both of these topics will get substantially more complex as we continue to build bigger apps with more moving parts, so keep up the focus and hard work!

[droberts-sea]

Good job wrapping this dynamic content in a sectioning element. Much cleaner than having a bunch of free-floating <p> tags.