Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Kate Evans-Spitzer - JS Scrabble #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Guribot
Copy link

@Guribot Guribot commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I definitely have a better concept of designing single-responsibility classes and functions than I did when working on our Ruby Scrabble project, which made the design process much smoother.
What was a challenge you were able to overcome on this assignment? The way that JavaScript handles symbols/strings as keys in objects is slightly different from Ruby, and I spent a few minutes trying to solve a problem that it turned out I didn't actually have (passing a string through as a key).
What is your favorite thing about learning a new programming language? Understanding where some of Ruby's shorthand comes from/what Ruby has been doing behind the scenes, feeling like I have more control over certain things
What is your least favorite thing about learning a new programming language? When things are more verbose/can't be condensed onto a single line, even though this is kind of in direct opposition to my answer above
Do you have any recommendations on how we could improve this project for the next cohort? Nope! Coming back to the basic elements of a previous project was a nice way of keeping the focus on learning a new language.

@PilgrimMemoirs
Copy link

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Mostly Good - should have more commits towards end
Comprehension questions Well Done
General
score calculates score, has appropriate params and return value Well Done
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well Done
Has highestScoringWord and highestWordScore functions Some Improvement - these functions should utilize functionality defined in Scrabble to determine the output - right now the play() function is missing some of the rules regarding what determines a highest scoring word (like in the event of ties).
Overall
Area to improve: Identify where functionality can be reused to maintain DRY code.
Submission meets project expectations, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants