Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amy Lee -- Carets #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Amy Lee -- Carets #36

wants to merge 1 commit into from

Conversation

ayjlee
Copy link

@ayjlee ayjlee commented Nov 17, 2017

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to translate over some techniques for
What was a challenge you were able to overcome on this assignment? Understanding a little bit more about scope, especially in terms of using 'this', in Javascript, as well as the subtle differences in Javascript Objects and Classes vs. Ruby Hashes and Classes.
What is your favorite thing about learning a new programming language? It's interesting to see the syntax of new languages and be able to see the strengths of one language over another. Seeing the overlap and the divergences in languages, and thinking through why one is designed a certain way is also interesting. Also, just being able to expand my knowledge of what's out there, and what programming languages are capable of is exciting.
What is your least favorite thing about learning a new programming language? Little nuances in syntax, like missing semicolons or misplaced commas/spaces, cause some grief. Also, knowing there is a cleaner/more elegant way to do something in a different language is sometimes frustrating.
Do you have any recommendations on how we could improve this project for the next cohort?
Side Note I would like to flag that I somehow totally forgot about doing regular commits on this project. Will be better about this moving forward!

@tildeee
Copy link

tildeee commented Nov 20, 2017

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene amy!!!!! you forgot to git!!!!! haha, it's no problem :)
Comprehension questions amy!!!!!!! you forgot to complete a sentence in the first question!!! 😄
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall 👍

Good job overall! Nice use of arrow functions when applicable, good style overall, functional, hits all of the conditions and requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants