Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stef -- Carets #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Stef -- Carets #32

wants to merge 5 commits into from

Conversation

SesameSeeds
Copy link

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Loops, instance methods, arrays, conditionals, classes... This is said with the assumption that I'm looking for a similar pattern in both languages. I absolutely can see the benefit to having learned one and being able to pick up another one fairly quickly as far as logic goes. Sytnax... Well that is a different story that takes time but that's what practice is for.
What was a challenge you were able to overcome on this assignment? Syntax differences. I wouldn't say overcome, but a solid work in progress and leaning towards recognizing issues faster. All the curly braces!
What is your favorite thing about learning a new programming language? That it's new and challenging. Oh and that it potentially can do some different things.
What is your least favorite thing about learning a new programming language? I dunno, I can say I probably would have enjoyed Javascript first... I could claim syntax but it's also an interesting thing to learn. Oh, and the linter, holy mother of all the things I had to 'mute'.
Do you have any recommendations on how we could improve this project for the next cohort? It was fine though repetitive (granted I can see the bonus to re-doing a project in two languages).

@CheezItMan
Copy link

CheezItMan commented Nov 19, 2017

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene more granular commits would be better, good commit messages
Comprehension questions The more you write with the linter the easier it will get. You'll write better code too!
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Doh! Your function only looks at the 1st two words.
Overall Word of advice, when you finish a project for now turn on the linter and fix the complaints it has. It will make your code cleaner and you'll learn some good practices. Otherwise this is really well done. Your highestScoringWord function only looks at the 1st two words! Otherwise it looks ok.

Z: 10
};


const Scrabble = {
score: function(word) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also write this like:

score() {


totalScore() {
let total = 0;
for (let word of this.plays) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, using forEach is preferred however.


highestScoreFrom: function(arrayOfWords) {
let wordOne = arrayOfWords[0];
Copy link

@CheezItMan CheezItMan Nov 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only seems to work with an array of 2 words?
@SesameSeeds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants