pipes | amy angela sara tanisha | bEtsy

[tanham]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We began by trying to tackle things that we were each least comfortable with. Very early on we found that a lot functionality was dependent on pieces that others were working on so we had to restructure our roles. We each fell into things we were more comfortable with but still tried to challenge ourselves.
How did your team utilize git to collaborate?	We made use of branches with a general rule that we should work on a branch until a feature works. We looked at past commits often. As the project progressed, we learned to be more descriptive in our commit messages to better communicate.
What did your group do to try to keep your code DRY while many people collaborated on it?	Often we would write the code so it would work and then go back and refactor. We also usually tested each others code.
What was a technical challenge that you faced as a group?	Oh boy ... We had a really hard time working out the order functionality including quantity, adding to cart, removing from cart, stock inventory, viewing the cart, etc. The order table was a task that all four of us worked on during both weeks.
What was a team/personal challenge that you faced as a group?	Health was a challenge, physically and emotionally. All four of us had one full day of feeling dumb or not doing enough to contribute. While we had our challenges we communicated and were open about our feelings and so held each other up.
What could your team have done better?	We should have paired more. The few times that we put our heads together we solved hard problems quicker.
What was your application's ERD? (include a link)	its on the trello board
What is your Trello URL?	https://trello.com/b/14Nb0ITs/besty-satiety
What is the Heroku URL of your deployed application?	satiety.herokuapp.com

[PilgrimMemoirs]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	There is imbalance in commits - if pairing, make sure to switch roles or document in Trello.
Answered comprehension questions	Well Done - nice reflection
Trello board is created and utilized in project management	Some Improvement - See Trello note below
Heroku instance is online	Mostly Good - OAuth not working
General
Nested routes follow RESTful conventions	Some Improvement - remove any not being used or repeated. Couple custom routes not following REST convention
oAuth used for User authentication	Well Done - Is not setup on Heroku, have environment variables been set? (https://devcenter.heroku.com/articles/config-vars#setting-up-config-vars-for-a-deployed-application)
Functionality restricted based on user roles	Some Improvement - Can't edit product if not logged in. But as a logged in user, I can edit any product. And I can review my own product.
Products can be added and removed from cart	Well Done
Users can view past orders	Not Complete
Merchants can add, edit and view their products	Well Done
Errors are reported to the user	Mostly Good - errors for billing, like length of credit card is not shown.
Order Functionality
Reduces products' inventory	Some Improvement - sometimes works with numbers that are less than stock - and when entering over or equal, it appears to process the order but inventory does not change.
Cannot order products that are out of stock	Some Improvement - inventory doesn't change as expected
Changes order state	Not Complete - As a merchant, I don't see anything that has been ordered from me to continue changing the status.
Clears current cart	Well Done
Database
ERD includes all necessary tables and relationships	Mostly Good - not updated with new Billing table
Table relationships	Mostly Good - Missing relationship with billing and order
Models
Validation rules for Models	Well Done
Business logic is in the models	Well Done
Controllers
Controller Filters used to DRY up controller code	Mostly Good
Testing	89 tests, 187 assertions, 4 failures, 3 errors, 0 skips
Model Testing	Some Improvement - Missing for Merchant
Controller Testing	Some Improvement / Not all Complete - Merchant not complete, Orders not complete, Order_products has none. Categories and Products are mostly good.
Session Testing	Not Complete
SimpleCov at 90% for controller and model tests	Needs Improvement - 33.85%
Front-end
The app is styled to create an attractive user interface	Mostly Good - Feels incomplete on some pages and is hard to read content. Give more space on sides of main content, especially tables.
The app layout uses Foundation's Grid	Needs Improvement - Barely used
Content is organized with HTML5 semantic tags	Needs Improvement - very few semantic sectioning tags, some divs that wrap around a chunk of code would be more appropriate to have a sectioning tag like <section> or <article>
CSS is DRY	Mostly Good - There's two application files (keep only the scss one) a style targeting body should be in application.scss, not products.
Overall
Trello	It doesn't look like it being consistently updated, or at least at end. It is hard to know who worked on each task, Not all cards have an assignee. The trello board is a good opportunity to acknowledge any pairing that happened, since it won't be reflected in commits.
	I agree with the responses to the comprehension questions, more pairing and utilizing each other would have progressed this project further than it's current state.
More Feedback	More specific feedback will be provided as inline comment in the submitted PR code

IMPORTANT: Whoever submitted the PR (and thus will get the notification about this feedback) should share this with their teammates.