pipes - Tamira Kimberley Nkiru Diane - betsy

[tvojnar]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We split it up by models and controllers and stay within which one we were assigned to. When functionality overlapped we worked together. We also split things up by priority. We also paired on some of the more difficult problems.
How did your team utilize git to collaborate?	We worked on branches and merged them using pull requests.
What did your group do to try to keep your code DRY while many people collaborated on it?	Comments helped to keep our code dry. We tried to track any redundancies we saw. Keeping our code DRY as a group was one of our major challenges.
What was a technical challenge that you faced as a group?	CSS overriding other peoples work if we didn't use specific enough styling tags. This was more of a problem because we we're all working on CSS at the same time. We also faced nested routes and many to many relationships together.
What was a team/personal challenge that you faced as a group?	We had different communication styles, coding styles, and assumptions about group work that we had to work though. We also had to work through low moral when were getting started.
What could your team have done better?	Communication! And more pairing. More communication around what we had worked on individually.
What was your application's ERD? (include a link)	https://static1.squarespace.com/static/54bc2955e4b0b0eaa10e5a2b/59f3a40f109526e333fb41f6/59f3b5532774d1f13fb7d947/1509143897086/erd.jpg?format=2500w
What is your Trello URL?	https://trello.com/b/bDjjaiEF/betsy
What is the Heroku URL of your deployed application?	https://vineandbloom.herokuapp.com/products/new

[PilgrimMemoirs]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Well Done
Answered comprehension questions	Well Done
Trello board is created and utilized in project management	Mostly Good - make sure to include names on all tasks - easier to know who to go to if there's a question about that feature. It can also reflect pairing, where commits are only under one name.
Heroku instance is online	Well Done - oauth not working, did you set environment variables?
General
Nested routes follow RESTful conventions	Well Done
oAuth used for User authentication	Well Done
Functionality restricted based on user roles	Well Done
Products can be added and removed from cart	Mostly Good - Adding the same item twice creates two different order_products instead of updating the one that's there. I was able to checkout a product that only stated it had 36 available, by adding 7 the first time and 30 the second time, within the same cart.
Users can view past orders	Not Complete
Merchants can add, edit and view their products	Well Done
Errors are reported to the user	Well Done
Order Functionality
Reduces products' inventory	Well Done
Cannot order products that are out of stock	Mostly Good - see note above on 'products can be added and removed from a cart'
Changes order state	Well Done
Clears current cart	Well Done
Database
ERD includes all necessary tables and relationships	Mostly Good - Needs to be updated. Is missing Billings table. Photo isn't very clear, after white boarding use a digital tool so that you can update as necessary and have something easier to reference.
Table relationships	Well Done
Models
Validation rules for Models	Well Done - Opportunity for more in billing
Business logic is in the models	Mostly Good - Merchant methods are good, but if they're instance methods, do you need to pass the merchant instant in as an argument? If it's being called on a merchant instance, you can refer to that instance in it's method using self.
Controllers
Controller Filters used to DRY up controller code	Well Done
Testing	162 tests, 399 assertions, 1 failures, 0 errors, 0 skips
Model Testing	Mostly Good - Be sure to also have positive and negative test cases for validations like review only having a rating as an integer, with that integer needing to be between your set range.
Controller Testing	Mostly Good
Session Testing	Mostly Good
SimpleCov at 90% for controller and model tests	Well Done - 89.54% (I'll let the .45% slide for now)
Front-end
The app is styled to create an attractive user interface	Well Done
The app layout uses Foundation's Grid	Well Done
Content is organized with HTML5 semantic tags	Mostly Good - be mindful of indentation
CSS is DRY	Mostly Good - when defining fonts, create one ruleset for it and apply as many selectors that are going to use it - easier to change later on. Similar for something like text-align: center; Avoid static measurements.
Overall
	Great job coming together and achieving the requirements of the project.

IMPORTANT: Whoever submitted the PR (and thus will get the notification about this feedback) should share this with their teammates.