Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kayla Ecker - Caret #43

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Kayla Ecker - Caret #43

wants to merge 13 commits into from

Conversation

kaylaecker
Copy link

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How do Backbone Views help structure your code? *reminder to self - creating pull request as it is after 9, need to push wave 3 to master and fill out this form still <3
Did you use jQuery directly in your Views? How, and why?
What was an example of an event you triggered? Why did you need to trigger it?
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?

@CheezItMan
Copy link

Ada Trader

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene For the functionality, you have enough commits, good commit mesages
Comprehension questions MISSING
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Functionality
Quote prices change when clicking Buy and Sell Check
The Trade History updates when buying and selling a quote Check, interesting choice with the history view. You did show some master by having the Quote instances signal the HistoryView with the custom event. Nice work on that.
A user can create an open order using the Order Entry Form MISSING
An open order removes itself from the open orders and updates the Trade History when fulfilled MISSING
General
Has separate views for different parts of the app For both the Quote, and QuoteView & HistoryView, Orders is missing.
Uses events (listening/handling and triggering) to manage different behavior in views Only for Quotes and QuoteList
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render) Check for what is completed.
Error handling for the Order Entry Form MISSING
Testing
Has unit tests for models MISSING
Overall You have significant portions missing, you didn't complete the Orders part of the assignment. Perhaps you ran out of time, but there's a lot not complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants