pipes | tanisha | ada trader

[tanham]

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How do Backbone Views help structure your code?	backbone views removes code that deals with user interface from the app.js to allow for cleaner code
Did you use jQuery directly in your Views? How, and why?	no, anytime I wanted to grab a DOM element, I used this. before it.Using this puts the jQuery selector in the context of that particular view. Without that context, the selector would be look through the entire project and so you would need to use ids to be more specific.
What was an example of an event you triggered? Why did you need to trigger it?	in my quote view, I trigger a tradeUpdate in my buy and sell functions. the quote list view is listening for the trade update which is triggered in the buy or sell functions.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?

[droberts-sea]

Ada Trader

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
Organization
Models and collections are defined in separate files	yes
Code that relies on the DOM is located in or called by $(document).ready	yes
Functionality
Quote prices change when clicking Buy and Sell	yes
The Trade History updates when buying and selling a quote	yes
A user can create an open order using the Order Entry Form	yes
An open order removes itself from the open orders and updates the Trade History when fulfilled	no
General
Has separate views for different parts of the app	yes
Uses events (listening/handling and triggering) to manage different behavior in views	yes
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)	yes
Error handling for the Order Entry Form	no
Testing
Has unit tests for models	no :(
Overall	This is a good start. Your code for handling quotes and market orders looks good, and you're very close to having limit orders working. There's just a little more plumbing that needs to be done to ensure data is available where you need it. Keep up the hard work!

[droberts-sea]

Right now you only have the symbol for this quote, since that's what you get when you read the form. However, in order to connect all the pieces, you really need the Quote itself, not just the symbol. That will let the Order listen to events on the quote, validate the initial buy/sell price, etc.

One way to do this would be for the OrderListView to know about the QuoteList collection, passing it in as an extra property to the constructor from app.js. Then in QuoteList you could write a function that, given a symbol, returns the corresponding quote.

[droberts-sea]

I'm not sure I like the attribute name buy. A more descriptive way to go might be to call the attribute 'lastTradeType' and set it to 'buy' or 'sell'.

Since the type of the most recent trade isn't really relevant for the quote, an even better strategy would be to not set it on the model at all, but provide it as an extra parameter when you trigger the event:

this.trigger('tradeUpdate', this, true);

And then the event listener in QuoteListView:

trade: function(quoteView, buy) {
  const tradeData = quoteView.model.toJSON();
  tradeData.buy = buy;
  const compiledTradeTemplate = this.tradeTemplate(tradeData);
  // ...
}