Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roxanne Agerone and Kimberley Zell - Pipes - VideoStoreConsumer #22

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

kimpossible1
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Kimberley learned about modals, Roxanne learned about front end html and css stuff like making a hero section.
What was one area of Backbone you gained more clarity on during this assignment? Roxanne- I learned how to parse through the Backbone documentation on APIs. Although I kind of hacked one portion, it was helpful. Kimberley learned more on triggering events without a bus.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We re-rendered movielistview to display movies from the external API when a user uses the search bar. Otherwise we rendered movies from our rental library.
Describe how you handled rentals with Backbone? NA did not do it.
Describe a DOM event your application handled We had DOM events such as clicking on the MOvie Library button to view the REntal Library.
Describe a custom event your application handled We have a custom event that triggers opening a modal display.
Do you have any recommendations on how we could improve this project for the next cohort? NA, all good. More explicit instructions but otherwise good.

RAgerone and others added 30 commits December 18, 2017 11:51
Signed-off-by: Kimberley Zell <[email protected]>
…ything, as well as code we are not using and not going to use.
@droberts-sea
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution yes
Comprehension questions yes
General
Search functionality yes
Rental library listing functionality yes
Add to rental library functionality yes - I can't view details on a move from TMDB
Underscore Templates yes
Overall Look & feel lovely styling!
Optionals
Overall Good work overall!


add(newMovie) {
if(!newMovie.isValid()){
$('.display-status').html('')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems a little strange to me. It's defined on Movie, which implies you're currently inside a movie object, but it requires you to pass in a separate movie object and saves that to the database. Instead, it would probably be cleaner to have this function save this movie to the API, and call it on the new movie instead of the old.

Alternatively, you could say it's called on the old movie, but internally does the work of creating a new movie and saving that (work that is currently done in MovieView.add())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants