Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kay Kay and Tay Tay Blockbuster -- Carets #16

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

misstonbon
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Kayla: I learned styling and how to adapt API to project's needs.
Tanja: I learned to create application.js and keep app.js short and straightforward.
What was one area of Backbone you gained more clarity on during this assignment? Triggering events, passing events as object.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We don't remember that being a problem/don't understand the question.
Describe how you handled rentals with Backbone? We did not implement rentals.
Describe a DOM event your application handled Clicking on a movie title on the list and rendering its details.
Describe a custom event your application handled Movie search getting a val() from search bar and fetching movies from the DB.
Do you have any recommendations on how we could improve this project for the next cohort? nope.

@CheezItMan
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution Check
Comprehension questions Check, although you have an issue with the images related to that question about different content.
General
Search functionality Check
Rental library listing functionality Check
Add to rental library functionality Check
Underscore Templates Check
Overall Look & feel Simple, but it works
Optionals None
Overall You hit the major learning goals. The only issue was the images for IMDB movies not showing.


<script id="movie-info-template" type="text/template">
<h3> <%- title %></h3>
<img src="https://image.tmdb.org/t/p/w185/<%- image_url %>" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need an if statement here to get the images to show for IMDB movies, or you could work on the API end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants