Pipes - Irene D - MediaRanker

[idevera]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	Wrote a private method in the sessions controller to create a new user when they have no previously logged in
Describe how you approached testing that model method. What edge cases did you come up with?	Approach is to see if a method has one best case, worst case, and in between case. For instance, I tried to test what redirects would occur when a session was logged in and when a session was logged out for each method that required it.
Describe an edge case test you wrote for a controller	When there were no users and when there were no works stored in the database
What are session and flash? What is the difference between them?	Session information about a user for a period of time while flash is temporary and disappears after it is called
Describe a controller filter you wrote.	A before do block on the works controller to only allow specific the find_work action to run prior to initiation of the other methods that require it
What was one thing that you gained more clarity on through this assignment?	How to do controller and method testing. Also, attempted session testing.
What is the Heroku URL of your deployed application	https://rank-best-medias.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Too short of a week. More examples of flash and session and how to embed them into the html.

[PilgrimMemoirs]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Mostly Good - first question was asking about a model method, specifically.
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML
Errors are reported to the user	Well Done
Business logic lives in the models	❗️ Missing - Logic is not defined in models. See note on Organization of Logic code below
Models are thoroughly tested, including relations, validations and any custom logic	Good start - ❗️ Missing test for logic (related to note above with logic not defined in model)
Controllers are thoroughly tested	Well Done - (focused on works controller)
Wave 1 - Media
Splash page shows the three media categories	Mostly Good - (other than logic code mixed in views)
Basic CRUD operations on media are present and functional	Well Done
Wave 2 - Users and Votes
Users can log in and log out	Well Done
The ID of the current user is stored in the session	Well Done
Individual user pages and the user list are present	Well Done
A user cannot vote for the same media more than once	Well Done
All media lists are ordered by vote count	Mostly Good - Logic code should be in a custom model method
Splash page contains a media spotlight	Well Done - Mostly Good - Logic code should be in custom model method
Media pages contain lists of voting users	Well Done
Wave 3 - Styling
Foundation is used appropriately	Well Done
Look and feel is similar to the original	Well Done
Overall
Organization of Logic Code	Instead of having this in your views `<% works = Work.all.sort_by {
it "can be created if there are no previous users" do	This test is unnecessary - instead have tests for creating a valid user, not being to create user with invalid or missing data, and to make sure the users index page still loads with success if there are not any users. The connection of having no users and being to create one are not related to necessitate a test.