Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Eve #43

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Branches - Eve #43

wants to merge 4 commits into from

Conversation

tofuandeve
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice work, you hit the learning goals here. Well done.

Do take a look at my comment about refined super_digit.

Comment on lines +18 to +20
temp = results[0] + results[1]
results[0] = results[1]
results[1] = temp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

# Time Complexity - ?
# Space Complexity - ? (should be O(n))
# Time Complexity - O(n)
# Space Complexity - O(n) stack space
# Hint, you may want a recursive helper method
def fibonacci(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# Time Complexity - ?
# Space Complexity - ?
# Time Complexity - O(logn) n is the number itself
# Space Complexity - O(logn)
def super_digit(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/super_digit.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants