Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Amal #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Branches - Amal #32

wants to merge 2 commits into from

Conversation

ashassan
Copy link

@ashassan ashassan commented Sep 1, 2019

No description provided.

CheezItMan
CheezItMan reviewed Sep 4, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You hit all the learning goals here.

lib/array_equals.rb

if array1 == nil && array2 == nil
return true
elsif array1 == nil && array2 != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also do if array1.nil? || array2.nil? because you know by this point that they're not both nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashassan @CheezItMan