Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): remove bug-causing workaround for spurious small db files (fixes #466) #492

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Sep 23, 2024

Credit to @krzysid in #466 (comment)

Important

Removes size-based filtering of database files in pull() in sync_wrapper.rs, fixing a bug with spurious small files.

  • Behavior:
    • Removes filtering of database files smaller than 50kB in pull() in sync_wrapper.rs.
    • Now processes all .db files regardless of size.
  • Misc:
    • Fixes bug related to spurious small database files during sync.

This description was created by Ellipsis for 952716a. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 952716a in 8 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw-sync/src/sync_wrapper.rs:41
  • Draft comment:
    The removal of the filter for small database files should resolve the issue of not finding any database files, as it allows all files to be considered. The logic for selecting the largest database file remains intact, which is a good practice to ensure the most complete data is used.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR removes a filter that excluded small database files. This change should resolve the issue of not finding any database files, as it allows all files to be considered. However, the logic for selecting the largest database file remains intact, which is a good practice to ensure the most complete data is used.

Workflow ID: wflow_pD3sSLdypSAOqMUk


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare ErikBjare merged commit 5738246 into master Sep 23, 2024
7 checks passed
@ErikBjare ErikBjare deleted the dev/fix-filtering-small-db-workaround branch September 23, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant