Add sd-notify #489
Merged
Add sd-notify #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5031d85 in 28 seconds
More details
- Looked at
61lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_sPXk7KCNlx1yfxKX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
I'm going to add not yet existing service to aw-awatcher at 2e3s/awatcher#23 |
Currently, services dependent on aw-server.service (e.g. aw-awatcher) start just after its launch. This patch causes systemd to launch the dependent services only after the rocket server is up an running. It's aimed to help slow systems to not close the dependent service prematurely due to not being able to connect to the server.
|
ping |
|
@wojnilowicz Erik is currently on vacation. He'll review it when he's back. Thanks for the PR. |
|
ping |
|
Nice, thanks for the PR and ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, services dependent on aw-server.service (e.g. aw-awatcher) start just after its launch.
This patch causes systemd to launch the dependent services only after the rocket server is up an running.
It's aimed to help slow systems to not close the dependent service prematurely due to not being able to connect to the server.
Summary:
Change systemd service type to
notifyand integratesd-notifyto signal readiness inaw-server.Key points:
Typefromsimpletonotifyinaw-server.service.sd-notifydependency inaw-server/Cargo.toml.aw-server/src/main.rsto usesd_notify::notifyto signal readiness after Rocket server ignition.Generated with ❤️ by ellipsis.dev