Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused multipart dependency #481

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

wojnilowicz
Copy link
Contributor

@wojnilowicz wojnilowicz commented May 12, 2024

🚀 This description was created by Ellipsis for commit 4089ba4

Summary:

This PR removes the unused multipart dependency from the aw-server project, simplifying the dependency tree.

Key points:

  • Removed multipart dependency from aw-server/Cargo.toml

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4089ba4 in 29 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw-server/Cargo.toml:16
  • Draft comment:
    Please confirm that the multipart dependency is not used anywhere in the codebase. Removing a dependency without ensuring it's unused could lead to runtime errors.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_rEwz4l6aRAQqmIQS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

8 days left in your free trial, upgrade for $20/seat/month or contact us.

@wojnilowicz
Copy link
Contributor Author

ping

1 similar comment
@wojnilowicz
Copy link
Contributor Author

ping

@ErikBjare
Copy link
Member

ErikBjare commented Jun 10, 2024

I thought this multipart thing was used somewhere? @johan-bjareholt

Are you sure it's not an extra for some other crate? Otherwise, I'll happily merge this. Sorry for the delay.

@wojnilowicz
Copy link
Contributor Author

wojnilowicz commented Jun 10, 2024

I thought this multipart thing was used somewhere? @johan-bjareholt

Are you sure it's not an extra for some other crate? Otherwise, I'll happily merge this. Sorry for the delay.

No problem. As you might already know, I try to package it for Fedora, and still have some dependencies in-progress until I finally get to the aw-server-rust.

multipart is a big dependency to package though, and I successfully built (as I want to package it for Fedora) and run aw-server-rust without it, so I want to unload it 🙂

Do you have any idea why is clippy complaining? Environmental issue?

@ErikBjare
Copy link
Member

Ah, I see! Yeah sure, let's remove it.

I'm not sure why clippy is complaining, but looks like we have the same issue on master, so no worries.

@ErikBjare ErikBjare merged commit 5a51fb9 into ActivityWatch:master Jun 10, 2024
6 of 7 checks passed
@ErikBjare
Copy link
Member

I've updated the Cargo.lock as well on the master branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants