Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scss file update #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

physicist-dev
Copy link

@physicist-dev physicist-dev commented Aug 11, 2024

  1. I added SASS folders in src/assets following 7 in 1 architecture.
  2. Updated scripts in package.json for sass.
  3. Added BEM & SASS reference for understanding purposes.
  4. Added SCSS utility in mixins & utilities with comments
  5. I added 3rd party md and gave the attribution to the authors.

🚀 This description was created by Ellipsis for commit fc9c94d

Summary:

This PR adds a structured SASS architecture, updates build scripts, and includes documentation and third-party attributions.

Key points:

  • Added SASS folders in src/assets using 7-in-1 architecture.
  • Updated package.json with scripts for SASS compilation, prefixing, and compression.
  • Added BEM reference.md and SCSS references.md for documentation.
  • Created THIRD_PARTY_LICENSES.md for third-party attributions.
  • Implemented SCSS utilities in src/sass/_utilities.scss and mixins in src/sass/_mixins.scss.
  • Main SCSS file src/sass/main.scss imports all components in a specific order.

Generated with ❤️ by ellipsis.dev

physicist-dev and others added 4 commits August 11, 2024 13:23
1) Updated File paths in package.json; added license (MPL).
2) Updated README.md; start-server, build:css, live-server.
3) Added SCSS files in assests
4)Added  style.css in assets.
5) Added JS> script.js in assets.
6) Added 3rd Party License.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fc9c94d in 14 seconds

More details
  • Looked at 461 lines of code in 16 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. SCSS references.md:24
  • Draft comment:
    There's a syntax error in the mixin definition and usage example:
@mixin mixin-name{
    // Code Goes here
}

And to call a mixin, it should be:

.img{
    @include mixin-name;
}

Please correct the mixin definition and its usage example.

  • Reason this comment was not posted:
    Multiple suggestions found in comment body, which is not allowed by GitHub

Workflow ID: wflow_gU2VUVp7xTkLL9rb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@brayo-pip
Copy link
Member

Looks good. But still using bootstrap. You should also remove this import then try to style using scss.

@ErikBjare
Copy link
Member

ErikBjare commented Aug 11, 2024 via email

@brayo-pip
Copy link
Member

Will look into shadcn. I have limited experience with tailwind but I guess I could manage a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants