Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw numexpr engine #70

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Raw numexpr engine #70

wants to merge 6 commits into from

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Oct 29, 2024

This pull request includes several enhancements and bug fixes in the sharrow/relationships.py and sharrow/tree_branch.py files. The most important changes include adding a new CachedTree class, updating the get_expr method to support a new pandas-numexpr engine, and improving the eval method to handle numeric values.

Enhancements:

  • New Class Addition:

    • Added CachedTree class to cache the results of getitem calls in sharrow/tree_branch.py.
  • Method Updates:

    • Updated get_expr method in sharrow/relationships.py to support a new pandas-numexpr engine and added a parser argument for better expression evaluation. [1] [2] [3]
    • Enhanced eval method in sharrow/relationships.py to handle numeric values and booleans, broadcasting them appropriately to the root dimensions.

Bug Fixes:

  • Parameter Validation:
    • Added a check in eval_many method to raise a ValueError when no expressions are provided.

Code Imports:

  • Additional Imports:
    • Added Number from numbers to sharrow/relationships.py.
    • Imported CachedTree in sharrow/relationships.py.

These changes collectively improve the efficiency and robustness of expression evaluation and data handling in the sharrow package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant