Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Models for Independence from the Rails App #41

Merged
merged 8 commits into from
Feb 10, 2017

Conversation

no-reply
Copy link
Member

@no-reply no-reply commented Feb 3, 2017

Migrates models and their associated builders from app to lib. This makes it possible to require and work with the models, independent from any dependency on rails.

Documentation and tests are added, where they were lacking in the app versions.

The commits are structured to keep the refactor under green. I'm happy to squash them into larger chunks, if that's best.

Setting is aliased to the newer LinkedDataFragments::Settings, due to the stubbing described in #38. If that ticket is resolved, we can deprecate the alias.

This is a follow-up to the work in #38.

Tom Johnson added 8 commits February 3, 2017 13:30
Duplicates model behavior from `app` in `lib`. This is part of a
stepwise refactoring.
Refactor `HydraTemplate` into lib and into the `LinkedDataFragments`
namespace. This continues the refactor.
Nice work everyone, this one's a one liner!
Completes the break from the `app` builders.
Completes the break from the app models, to the lib versions.
This alias preserves backward compatibility. This is necessary while we
make a more clean break (there are a large number of stubs on `Setting`).
@no-reply no-reply changed the title Refactor Models for independence from the Rails App Refactor Models for Independence from the Rails App Feb 3, 2017
Copy link
Contributor

@scande3 scande3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all fine to me!

@scande3 scande3 merged commit f6d2e49 into master Feb 10, 2017
@no-reply no-reply deleted the feature/refactor-models branch February 10, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants