Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added marshaling and pre-unmarshaling hooks for buildscript <-> buildexpression. #3480

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Added marshaling and pre-unmarshaling hooks for buildscript <-> buildexpression. #3480

merged 1 commit into from
Sep 9, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 6, 2024 •
edited by github-actions bot
Loading

TaskDX-3031 Our buildscript package can mediate evaluation of client-side functions

This allows for outside packages to hook into:

  • Unmarshaling from buildexpression to buildscript
  • Marshaling from buildscript to buildexpression

Also: utilize this when marshaling Req() function to legacy object format. We cannot utilize the unmarshaling yet.

@mitchell-as
Added marshaling and pre-unmarshaling hooks for buildscript <-> build…
4cea332 
…expression.

This allows for outside packages to hook into:
- Unmarshaling from buildexpression to buildscript
- Marshaling from buildscript to buildexpression
@mitchell-as mitchell-as changed the base branch from master to version/0-47-0-RC1 September 6, 2024 17:03
@mitchell-as mitchell-as requested a review from Naatan September 6, 2024 18:46
@mitchell-as mitchell-as marked this pull request as ready for review September 6, 2024 18:46
Naatan
Naatan approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much simpler than I was expecting!

@mitchell-as mitchell-as merged commit 3a01a78 into version/0-47-0-RC1 Sep 9, 2024
13 of 18 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3031 branch September 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan approved these changes

Assignees
No one assigned
Labels
Test: buildscripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @Naatan