Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent concurrency errors with envdef loading. #3469

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Aug 30, 2024

BugDX-3009 fatal error: concurrent map read and map write in envdef.Collection.Load

@mitchell-as mitchell-as changed the title Prevent concurrent reads as well. Prevent concurrency errors with envdef loading. Aug 30, 2024
@mitchell-as
Copy link
Contributor Author

The lone test failure is unrelated to this PR.

@mitchell-as mitchell-as requested a review from Naatan August 30, 2024 18:54
@mitchell-as mitchell-as marked this pull request as ready for review August 30, 2024 18:54
@mitchell-as mitchell-as closed this Sep 3, 2024
@mitchell-as mitchell-as reopened this Sep 3, 2024
@mitchell-as mitchell-as merged commit 1aedb1c into version/0-46-0-RC1 Sep 3, 2024
16 of 17 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3009 branch September 3, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants