Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove the installation.InstallDirMarker after binaries were successfully removed. #3414

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Jul 24, 2024

BugDX-2870 Could not register config listener: Could not determine install root from exec:

Otherwise, if removal of state-svc failed and it's scheduled for auto-start, it'll constantly fail to detect the install root and send the error to rollbar.

…cessfully removed.

Otherwise, if removal of state-svc failed and it's scheduled for auto-start, it'll constantly fail to detect the install root and send the error to rollbar.
set success=false
) else (
echo "Successfully removed path %%i" >> %logfile%
if "%success%"=="true" (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch has no way to break out of a for loop, so we'll just skip over removal of the rest of the paths if one removal failed.

@mitchell-as mitchell-as requested a review from MDrakos July 24, 2024 16:41
@mitchell-as mitchell-as marked this pull request as ready for review July 24, 2024 16:41
@mitchell-as mitchell-as merged commit 792d654 into version/0-46-0-RC1 Jul 24, 2024
10 of 14 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2870 branch July 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants