Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable localcommits and buildscripts. #3037

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Re-enable localcommits and buildscripts. #3037

merged 4 commits into from
Jan 22, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Jan 19, 2024 •
edited by github-actions bot
Loading

TaskDX-2458 Enable local orders on v0.44

@mitchell-as
Copy link
Contributor Author

mitchell-as commented Jan 22, 2024 •
edited
Loading

Test failures do not appear to be caused by this changset.

There are a couple timeouts due to artifact download failures.

The one troubling error is the TestPackage_Duplicate test. I thought it was fixed in the buildplanner API, which this PR does not touch. If you have any insights, please let me know.

@mitchell-as mitchell-as requested a review from MDrakos January 22, 2024 21:30
@mitchell-as mitchell-as marked this pull request as ready for review January 22, 2024 21:30
@mitchell-as
Copy link
Contributor Author

You've already reviewed this in depth in #2897. The only change from that PR is here: 89371f5. Feel free to gloss over the rest.

MDrakos
MDrakos approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestPackage_Duplicate is the only test that is failing across all 3 platforms and could be related to this change but unlikely. May want to confirm before merging.

@mitchell-as mitchell-as reopened this Jan 22, 2024
@mitchell-as mitchell-as merged commit cb17052 into version/0-44-0-RC1 Jan 22, 2024
10 of 13 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2458 branch January 22, 2024 22:24
as-builds added a commit that referenced this pull request Jan 22, 2024
@as-builds
Merge branch version/0-44-0-RC1 to adopt changes from PR #3037
a13c3ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos