Added state revert HEAD to revert latest commit.
#2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Dec 14, 2023
•
mitchell-as
commented
 DX-136 `state revert HEAD` reverts the HEAD commit
|
github-actions
bot
changed the base branch from
master
to
version/0-43-0-RC1
mitchell-as
force-pushed
the
mitchell/dx-136
branch
from
cc9f537 to
cc9fcfb
Compare
MDrakos
requested changes
Dec 15, 2023
internal/runners/revert/revert.go
Outdated
| if !strfmt.IsUUID(params.CommitID) { | ||
|
|
||
| commitID := params.CommitID | ||
| if !strfmt.IsUUID(commitID) && commitID != headCommitID { |
There was a problem hiding this comment.
I think here and the other equality check with the constant should be case insensitive. I think strings.EqualFold will get you there.
MDrakos
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.