Added comprehensive test for determining the current project. #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDrakos
requested changes
Dec 13, 2023
There was a problem hiding this comment.
While I think the test you've setup is great it makes more sense as an integration test. When we're setting env vars in the test because certain commands do it signals to me that the behavior should be covered by an integration test. Right now, if we were to inadvertently change the behavior of state shell this unit test wouldn't fail, whereas if this was an integration test we would catch it.
Comment on lines
+761
to
+764
| // It considers projects in the following order: | ||
| // 1. Environment variable (e.g. `state shell` sets one) | ||
| // 2. Working directory (i.e. walk up directory tree looking for activestate.yaml) | ||
| // 3. Fall back on default project |
mitchell-as
force-pushed
the
mitchell/dx-2360
branch
from
5c5403a to
97e9c61
Compare
MDrakos
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also upgraded the existing unit test for this.