Added comprehensive test for determining the current project. #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-1222
branch
from
977d6fb to
e6183ee
Compare
mitchell-as
force-pushed
the
mitchell/dx-1222
branch
from
e6183ee to
98358ef
Compare
|
Closing because its ticket has the dreaded "Any" fix version that cannot be removed. Will open another PR for a duplicate ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already a unit test for this that I co-opted and made more clear. Note that documentation-wise, we're half blocked by https://activestatef.atlassian.net/browse/DX-2167, which is supposed to solidify the actual project resolution order, so this test and its underlying code could change after that ticket is resolved.