Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox test environment #2941

Merged
merged 59 commits into from
Jan 4, 2024
Merged

Sandbox test environment #2941

merged 59 commits into from
Jan 4, 2024

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Dec 12, 2023 •
edited by github-actions bot
Loading

TaskDX-2285 Our integration test environment is completely sandboxed

@github-actions github-actions bot changed the base branch from master to version/0-43-0-RC1 December 12, 2023 00:04
@MDrakos MDrakos closed this Dec 13, 2023
@MDrakos MDrakos reopened this Dec 13, 2023
@MDrakos MDrakos marked this pull request as ready for review December 19, 2023 20:33
@MDrakos MDrakos requested a review from mitchell-as December 19, 2023 20:54
mitchell-as
mitchell-as requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite good overall, with my only real concern being that it might be too finely-tuned for running on GitHub Actions CI that it might not run on our systems locally (at least for Windows).

.github/workflows/build.yml Outdated
@@ -106,6 +105,13 @@ jobs:
run: |
echo "${PSScriptRoot}/.github/deps/${{ runner.os }}/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append

- # === Setup Windows ===
name: Debug (Windows)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this block in? If not, can we just revert all changes from this file? I'm a bit nervous with the quoting changes on lines 267 and 292 below.

.github/workflows/build.yml Outdated
@@ -258,7 +264,7 @@ jobs:

- # === Deploy for Integration Tests # NEVER run this against production branches. This is meant for PR deployments. ===
name: Deploy for Integration Tests # NEVER run this against production branches. This is meant for PR deployments.
if: "!contains(fromJSON('[\"refs/heads/beta\", \"refs/heads/release\", \"refs/heads/LTS\"]'), github.ref)"
if: '!contains(fromJSON(''["refs/heads/beta", "refs/heads/release", "refs/heads/LTS"]''), github.ref)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really allowed? It has me worried, because it doesn't look syntactically valid.

internal/testhelpers/e2e/env_windows.go
@@ -0,0 +1,37 @@
//go:build windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried running e2e tests locally with these changes? The variables defined here may be too finely-tuned for GitHub Actions CI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they ran fine on my local machine. We also can disable the sandbox with an env var if it's a problem. I expect there to be some issues with this and we can change it to opt-in as well as fine-tune the sandboxing if/when issues pop up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and as for the env vars on Windows they appear to be fairly standard, except for the msys one which should not only be prepended when on CI.

@MDrakos MDrakos requested a review from mitchell-as December 21, 2023 23:00
mitchell-as
mitchell-as previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. I know this was a major pain, but kudos for sticking with it!

@MDrakos
Copy link
Member Author

MDrakos commented Jan 3, 2024

Test failures should be unrelated to this PR

@MDrakos MDrakos requested a review from mitchell-as January 3, 2024 23:19
@MDrakos MDrakos merged commit 91f0fd8 into version/0-43-0-RC1 Jan 4, 2024
7 checks passed
@MDrakos MDrakos deleted the DX-2285 branch January 4, 2024 16:49
as-builds added a commit that referenced this pull request Jan 4, 2024
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2941
eedca72
MDrakos added a commit that referenced this pull request Jan 9, 2024
@MDrakos
Revert "Merge pull request #2941 from ActiveState/DX-2285"
2994d0c 
This reverts commit 91f0fd8, reversing
changes made to 372e2a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
Test: critical Test: install-scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MDrakos @mitchell-as