Only run Target GitHub Action on PR creation. #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/dx-1743
branch
2 times, most recently
from
31269d9
to
741a829
Compare
github-actions
bot
changed the base branch from
master
to
version/0-43-0-RC1
mitchell-as
force-pushed
the
mitchell/dx-1743
branch
from
741a829
to
a48ea3f
Compare
mitchell-as
changed the title
mitchell-as
force-pushed
the
mitchell/dx-1743
branch
from
a48ea3f
to
123e47b
Compare
MDrakos
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the last AC says only Verify should be required, I did not split up Target & Verify into separate actions because Verify implicitly depends on Target and I saw no easy way to make them sequential if they're separate actions (especially if Target is conditional). Instead, I just made Target only run on create, as specified in the ACs. This effectively makes it so that only Verify is required for merge.