Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give less confusing error message if a command without arguments received one. #2902

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Give less confusing error message if a command without arguments received one. #2902

merged 1 commit into from
Nov 28, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 28, 2023 •
edited by github-actions bot
Loading

TaskDX-2316 Investigate - "Too many arguments" error

Now running something like state auth signout results in

 x No such command: signout

and running state auth this does not exist results in

 x No such command: this

Running state does-not-exist results in

 x No such command: does-not-exist

as expected (this was always the case).

@mitchell-as mitchell-as requested a review from MDrakos November 28, 2023 16:12
@mitchell-as mitchell-as marked this pull request as ready for review November 28, 2023 16:12
MDrakos
MDrakos approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mitchell-as mitchell-as merged commit eccb361 into version/0-43-0-RC1 Nov 28, 2023
10 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2316 branch November 28, 2023 21:36
as-builds added a commit that referenced this pull request Nov 28, 2023
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2902
733457b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos