Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed version number on v43 branch. #2900

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fixed version number on v43 branch. #2900

merged 1 commit into from
Nov 28, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 27, 2023 •
edited by github-actions bot
Loading

BugDX-2329 Wrong build name (0.42...) in the `version/0-43-0-RC1` branch

I checked S3 and the correct folder (0.43.0) is populated (not 0.42.0).

We are going to have to try and prevent this one from propagating up when it's merged, or else it'll overwrite master's v44 version.txt.

@mitchell-as mitchell-as requested a review from MDrakos November 27, 2023 22:41
@mitchell-as mitchell-as marked this pull request as ready for review November 27, 2023 22:41
MDrakos
MDrakos approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yeah we will have to be careful with v43 ticket to ensure this doesn't change.

@mitchell-as mitchell-as merged commit 2407805 into version/0-43-0-RC1 Nov 28, 2023
14 of 18 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2329 branch November 28, 2023 21:54
as-builds added a commit that referenced this pull request Nov 28, 2023
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2900
ba566cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
Test: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos