Raise an error when updating a runtime currently in use. #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Nov 20, 2023
•
mitchell-as
commented
 DX-2091 We ensure the runtime is not in use before updating it
|
|
Test failures are not due to this PR. |
MDrakos
requested changes
Nov 21, 2023
pkg/platform/runtime/setup/setup.go
Outdated
| @@ -220,6 +235,35 @@ func (s *Setup) Update() (rerr error) { | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *Setup) getProcessesInUse() map[string]int32 { | |||
There was a problem hiding this comment.
I think it makes more sense for this function to be part of the osutils package and we can supply it the directory to compare. Also we could have os-specific versions of these functions to reduce the if statements here.
There was a problem hiding this comment.
Okay, I moved it into the osutils package. However, when I tried splitting it up into OS-specific functions, I ended up with too much duplication. I left it as a single function.
MDrakos
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.