Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "preserve.prompt" config option for not changing PS1 in activated environments. #2884

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 15, 2023

StoryDX-2152 Users Can Disable State Tool Prompt Edits

@mitchell-as mitchell-as requested a review from MDrakos November 15, 2023 17:39
@mitchell-as mitchell-as marked this pull request as ready for review November 15, 2023 17:40
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. My only contention is the actual config option itself. I feel like having ps1 in the config key name could be a bit too specific/technical. I'd like to get @rawktron's opinion on the key.

As it stands the user would run state config set preserve.ps1 true

@mitchell-as
Copy link
Contributor Author

I feel like anyone who actually cares about this setting would know what ps1 is :) I agree that @rawktron should approve this though.

@rawktron
Copy link
Member

I feel like anyone who actually cares about this setting would know what ps1 is :) I agree that @rawktron should approve this though.

What about preserve.prompt which is slightly more descriptive in terms of what it does?

This change is simply for users. Preserve the PS1 notation internally because it makes more sense.
@mitchell-as mitchell-as changed the title Added "preserve.ps1" config option for not changing PS1 in activated environments. Added "preserve.prompt" config option for not changing PS1 in activated environments. Nov 20, 2023
@mitchell-as
Copy link
Contributor Author

I've updated the user-facing config key to use preserve.prompt, but kept the internal PS1 references in the code because they make sense in that context.

@mitchell-as mitchell-as requested a review from MDrakos November 20, 2023 14:37
@mitchell-as mitchell-as merged commit f1da34b into version/0-43-0-RC1 Nov 20, 2023
6 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2152 branch November 20, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants