Lack of having a commit ID for push/pull is also an error. #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the base branch from
mitchell/dx-2277-2
to
version/0-42-0-RC1
mitchell-as
changed the base branch from
version/0-42-0-RC1
to
mitchell/dx-2277-2
MDrakos
requested changes
Oct 26, 2023
| @@ -264,24 +264,6 @@ func (suite *PushIntegrationTestSuite) TestPush_NoChanges() { | |||
| } | |||
| } | |||
|
|
|||
| func (suite *PushIntegrationTestSuite) TestPush_NoCommit() { | |||
There was a problem hiding this comment.
Isn't this still testing a valid error case? We could just update the test to reflect the changes in this PR.
There was a problem hiding this comment.
It's a duplicate of https://github.com/ActiveState/cli/pull/2842/files#diff-19c9e3245344660c63ba2f5d3cea1f3a8b8c3c04eebd39e59e24dd3b32e93707L248. This was testing a headless commit instance of the linked test.
MDrakos
previously approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not be merged before DX-2224 is.