Fixed sessionToken installer analytics. #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Oct 16, 2023
•
mitchell-as
commented
 DX-2228 Investigate missing session ID in state tool analytics
|
mitchell-as
force-pushed
the
mitchell/dx-2228
branch
2 times, most recently
from
441814d to
bedb894
Compare
mitchell-as
force-pushed
the
mitchell/dx-2228
branch
from
bedb894 to
e96ba60
Compare
|
Test failures are not due to this PR. They are due to existing, known issues and the usual timeouts. |
MDrakos
previously approved these changes
Oct 17, 2023
cmd/state-installer/cmd.go
Outdated
| } | ||
| err := cfg.Set(anaConst.CfgSessionToken, sessionToken) | ||
| if err != nil { | ||
| logging.Error("Unable to set session token: " + errs.JoinMessage(err)) |
There was a problem hiding this comment.
We may want to report this to rollbar so we can more easily diagnose if the issue of a missing session token comes up again.
There was a problem hiding this comment.
Yes, that's a good idea.
| suite.Require().NotEmpty(events) | ||
| for _, event := range events { | ||
| if event.Category == anaConst.CatInstallerFunnel && event.Dimensions != nil { | ||
| suite.Assert().NotEmpty(*event.Dimensions.SessionToken) |
There was a problem hiding this comment.
nit: We could assert the equality of the token value, not just is presence, as the comment above suggests.
There was a problem hiding this comment.
I've updated the comment. I am guilty of copy-pasting the code from another test :/ The important thing is that it's not empty because this value will ultimately depend on the session ID coming from the Platform.
MDrakos
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.