Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve node does not require runtime variable #2790

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Solve node does not require runtime variable #2790

merged 1 commit into from
Oct 4, 2023

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Oct 4, 2023 •
edited by github-actions bot
Loading

BugDX-2242 Unable to parse new build exprs using solve and a build function

@MDrakos MDrakos changed the base branch from master to version/0-41-0-RC2 October 4, 2023 20:46
@MDrakos MDrakos closed this Oct 4, 2023
@MDrakos MDrakos reopened this Oct 4, 2023
@MDrakos MDrakos marked this pull request as ready for review October 4, 2023 21:24
@MDrakos MDrakos requested a review from Naatan October 4, 2023 21:24
@Naatan Naatan requested review from mdrohmann and removed request for Naatan October 4, 2023 21:24
Naatan
Naatan reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagged Martin for review instead as he'll understand the implications of this change.

mdrohmann
mdrohmann approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@mdrohmann mdrohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks correct to me. Just look for * = solve or * = solve_legacy, where * could be any variable name, not just runtime.

👍

@MDrakos MDrakos merged commit 208e157 into version/0-41-0-RC2 Oct 4, 2023
10 checks passed
@MDrakos MDrakos deleted the DX-2242 branch October 4, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan left review comments

@mdrohmann mdrohmann mdrohmann approved these changes

Assignees
No one assigned
Labels
Test: critical Test: package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MDrakos @Naatan @mdrohmann