Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON messages in history #2751

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix JSON messages in history #2751

merged 2 commits into from
Sep 13, 2023

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Sep 12, 2023

BugDX-2195 Running `state history` in dashboard-created Windows project shows JSON in "changes" section

This change isn't ideal but it will work for now until we can get the history in the format of a build expression. Asked the Dashboard squad how they are handling this. Here is their changeset: https://github.com/ActiveState/TheHomeRepot/pull/11922/files.

Here is an example of the updated output:

█ Viewing Project History

Operating on project mitchell-as/docker, located at C:\Users\Mike\work\testing\docker.

Here are the most recent changes made to this project.

  Commit     a518738b-402b-404b-805f-97f9276f2cdf
  Author     mitchell-as
  Date       01 Sep 23 16:41 UTC
  Message    Not provided.
  Changes     - + Docker/Installer packagers
              - + python 3.10.12
              - + Platform

@github-actions github-actions bot changed the base branch from master to version/0-41-0-RC1 September 12, 2023 22:35
@MDrakos MDrakos requested a review from mitchell-as September 12, 2023 22:45
@MDrakos MDrakos marked this pull request as ready for review September 12, 2023 22:45
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but we should add some more tracking info.

pkg/cmdlets/commit/commit.go Show resolved Hide resolved
@MDrakos MDrakos requested a review from mitchell-as September 13, 2023 19:46
@MDrakos MDrakos merged commit 94fe1fe into version/0-41-0-RC1 Sep 13, 2023
6 checks passed
@MDrakos MDrakos deleted the DX-2195 branch September 13, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants